RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

[Kevin Driver]

On Fri, 4 Oct 2024 13:09:53 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8340327
>>  - more test, more RAW support, fix a bug on cleaning up getRawBytes output
>>  - add support for private class RawKeySpec
>>  - ensure key is intact after being used
>>  - renames
>>  - the fix
>
> src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java line 144:
> 
>> 142:     /// @return public key and private key (in this order) in raw bytes
>> 143:     /// @throws ProviderException if there is an internal error
>> 144:     public abstract byte[][] implGenerateKeyPair(String pname, SecureRandom sr);
> 
> Should be protected?

+1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1787975993