RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v58]
Rajan Halade
rhalade at openjdk.org
Thu Oct 17 20:47:22 UTC 2024
On Tue, 15 Oct 2024 22:55:17 GMT, Valerie Peng <valeriep at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> running the Exhaustive test through a more ruthless formatter
>
> test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 298:
>
>> 296: Utils.runAndCheckException(
>> 297: () -> KDF.getInstance(KDF_ALGORITHMS[0], (KDFParameters) new KDFAlgorithmParameterSpec()),
>> 298: ClassCastException.class);
>
> The ClassCastException is the result of line 297? I don't see the reason for testing this, seems nothing to do with the KDF impls?
I agree with @valeriepeng. These test calls can be removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1805405252
More information about the security-dev
mailing list