RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v58]

Kevin Driver kdriver at openjdk.org
Thu Oct 17 20:47:22 UTC 2024


On Thu, 17 Oct 2024 20:40:13 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 298:
>> 
>>> 296:     Utils.runAndCheckException(
>>> 297:         () -> KDF.getInstance(KDF_ALGORITHMS[0], (KDFParameters) new KDFAlgorithmParameterSpec()),
>>> 298:         ClassCastException.class);
>> 
>> The ClassCastException is the result of line 297? I don't see the reason for testing this, seems nothing to do with the KDF impls?
>
> I agree with @valeriepeng. These test calls can be removed.

Applied @rhalade's diff in: https://github.com/openjdk/jdk/pull/20301/commits/483ee9fde7951f2d7184ec5f2099bcf7cc5f0b6b

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1805411447


More information about the security-dev mailing list