RFR: 8298387: Implementing ML-DSA signature algorithm [v7]

[Sean Mullan]

On Tue, 15 Oct 2024 18:41:59 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   pack in-place and unpack with an offset

src/java.base/share/classes/sun/security/provider/SunEntries.java line 204:

> 202:         addWithAlias(p, "KeyFactory", "ML-DSA-44", "sun.security.provider.ML_DSA_Provider$KF2", attrs);
> 203:         addWithAlias(p, "KeyFactory", "ML-DSA-65", "sun.security.provider.ML_DSA_Provider$KF3", attrs);
> 204:         addWithAlias(p, "KeyFactory", "ML-DSA-87", "sun.security.provider.ML_DSA_Provider$KF5", attrs);

These should be separated and moved to the sections for each engine type.

src/java.base/share/classes/sun/security/util/KnownOIDs.java line 322:

> 320:     },
> 321: 
> 322:     //PQC

Nit, add space after "//".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1808863296
PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1808842489