RFR: 8298387: Implementing ML-DSA signature algorithm [v7]

[Weijun Wang]

On Mon, 21 Oct 2024 13:48:21 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   pack in-place and unpack with an offset
>
> src/java.base/share/classes/sun/security/provider/SunEntries.java line 204:
> 
>> 202:         addWithAlias(p, "KeyFactory", "ML-DSA-44", "sun.security.provider.ML_DSA_Provider$KF2", attrs);
>> 203:         addWithAlias(p, "KeyFactory", "ML-DSA-65", "sun.security.provider.ML_DSA_Provider$KF3", attrs);
>> 204:         addWithAlias(p, "KeyFactory", "ML-DSA-87", "sun.security.provider.ML_DSA_Provider$KF5", attrs);
> 
> These should be separated and moved to the sections for each engine type.

OK.

> src/java.base/share/classes/sun/security/util/KnownOIDs.java line 322:
> 
>> 320:     },
>> 321: 
>> 322:     //PQC
> 
> Nit, add space after "//".

OK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1809501450
PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1809501313