RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

[Weijun Wang]

On Fri, 30 Aug 2024 21:44:06 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 322:
>> 
>>> 320:          * Returns an unmodifiable {@code List} of input keying material values
>>> 321:          * in the order they were added. Returns an empty list if there are no
>>> 322:          * input keying material values.
>> 
>> Sean asked about where do the byte array IKMs go. Here you should mention that an IKM added by `{@link #addIKM(byte[])}` is converted to a `SecretKeySpec` object. Same for `salts`. Same as in `ExtractThenExpand`.
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. Please confirm if resolved.

I see them. Plural noun does not match singular one at:

Input keying material values added by {@link Builder#addIKM(byte[])}
         * are converted to a {@code SecretKeySpec} object.
         * 

Maybe "{@code SecretKeySpec} objects"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1742648974