RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

Kevin Driver kdriver at openjdk.org
Tue Sep 3 20:38:36 UTC 2024


On Tue, 3 Sep 2024 20:29:33 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. Please confirm if resolved.
>
> I see them. Plural noun does not match singular one at:
> 
> Input keying material values added by {@link Builder#addIKM(byte[])}
>          * are converted to a {@code SecretKeySpec} object.
>          * 
> 
> Maybe "{@code SecretKeySpec} objects"?

The passage you cited is grammatically correct. Many values are converted to one object.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1742657350


More information about the security-dev mailing list