RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

Weijun Wang weijun at openjdk.org
Tue Sep 3 22:07:35 UTC 2024


On Tue, 3 Sep 2024 20:35:58 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> I see them. Plural noun does not match singular one at:
>> 
>> Input keying material values added by {@link Builder#addIKM(byte[])}
>>          * are converted to a {@code SecretKeySpec} object.
>>          * 
>> 
>> Maybe "{@code SecretKeySpec} objects"?
>
> The passage you cited is grammatically correct. Many values are converted to one object.

Are you sure? When one call `addIKM(byte[])` multiple times, I can see in the code that each time a new `SecretKeySpec` object is added into the `ikms` list.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1742754910


More information about the security-dev mailing list