RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v9]

Volkan Yazici vyazici at openjdk.org
Fri Aug 29 13:48:54 UTC 2025


On Fri, 29 Aug 2025 06:48:00 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Rename `NoReplacement` suffix to `OrThrow`
>>  - Simplify `encodeWithEncoder` and trim long lines
>
> src/java.base/share/classes/java/lang/String.java line 1434:
> 
>> 1432:      *           having to declare the exception
>> 1433:      */
>> 1434:     private static <E extends Exception> byte[] encodeUTF8_UTF16(byte[] val, Class<E> exceptionClass) throws E {
> 
> Would it be possible to add a brief method description to this method? It's the equivalent of decoding val with the UTF-16 charset, then encoding the result with the UTF-8 charset, right?
> 
> In passing, if rename exceptionClass to exClass then you'll get get some back some of the horizontal space in several areas.

Pushed following changes:

- dae04e9e35e Improve Javadoc of touched `encode*()` methods
- b120d14fd96 Rename `exceptionClass` to `exClass`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2310204987


More information about the security-dev mailing list