RFR: 8348309: MultiNST tests need more debugging and timing

Hai-May Chao hchao at openjdk.org
Tue Feb 4 19:02:12 UTC 2025


On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> I need a review of this change that adds new timing controls for the initial server setup.  On rare occasions, more so on certain architectures, the server may not fully start before the client tries to connect.  Additional debugging is added to help identify if there are other timing issues.
> 
> Thanks
> 
> Tony

Changes look good. One small comment in TLSBase class.

Marked as reviewed by hchao (Committer).

test/jdk/javax/net/ssl/templates/TLSBase.java line 152:

> 150:         List<Exception> exceptionList = new ArrayList<>();
> 151:         ExecutorService threadPool = Executors.newFixedThreadPool(1,
> 152:             r -> Executors.defaultThreadFactory().newThread(r));

Do you think we may simplify this to `ExecutorService threadPool = Executors.newFixedThreadPool(1);` while this line is being changed?

-------------

PR Review: https://git.openjdk.org/jdk/pull/23407#pullrequestreview-2593778755
PR Review: https://git.openjdk.org/jdk/pull/23407#pullrequestreview-2593786603
PR Review Comment: https://git.openjdk.org/jdk/pull/23407#discussion_r1941737445


More information about the security-dev mailing list