RFR: 8348309: MultiNST tests need more debugging and timing
Anthony Scarpino
ascarpino at openjdk.org
Tue Feb 18 19:31:43 UTC 2025
On Tue, 4 Feb 2025 18:56:05 GMT, Hai-May Chao <hchao at openjdk.org> wrote:
>> I need a review of this change that adds new timing controls for the initial server setup. On rare occasions, more so on certain architectures, the server may not fully start before the client tries to connect. Additional debugging is added to help identify if there are other timing issues.
>>
>> Thanks
>>
>> Tony
>
> test/jdk/javax/net/ssl/templates/TLSBase.java line 152:
>
>> 150: List<Exception> exceptionList = new ArrayList<>();
>> 151: ExecutorService threadPool = Executors.newFixedThreadPool(1,
>> 152: r -> Executors.defaultThreadFactory().newThread(r));
>
> Do you think we may simplify this to `ExecutorService threadPool = Executors.newFixedThreadPool(1);` while this line is being changed?
Hmm. I'll try removing it to see if I get any failures. I don't remember why I added the threadfactory entry.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23407#discussion_r1960443504
More information about the security-dev
mailing list