RFR: 8349664: HEX dump should always use ASCII or ISO_8859_1 [v2]

Mikhail Yankelevich duke at openjdk.org
Wed Feb 19 17:07:33 UTC 2025


On Wed, 19 Feb 2025 16:52:36 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tests added
>
> test/jdk/sun/security/util/HexDumpEncoderTests.java line 101:
> 
>> 99:         public static void main(String[] args) throws Exception {
>> 100: 
>> 101:             try (final FileInputStream fis = new FileInputStream(args[0])) {
> 
> There is no need to read from a certificate. I think `encoder.encodeBuffer(new byte[100])` is enough.

changed in the next commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23661#discussion_r1962060893


More information about the security-dev mailing list