RFR: 8349664: HEX dump should always use ASCII or ISO_8859_1 [v2]

Weijun Wang weijun at openjdk.org
Wed Feb 19 17:14:57 UTC 2025


On Wed, 19 Feb 2025 17:04:15 GMT, Mikhail Yankelevich <duke at openjdk.org> wrote:

>> test/jdk/sun/security/util/HexDumpEncoderTests.java line 101:
>> 
>>> 99:         public static void main(String[] args) throws Exception {
>>> 100: 
>>> 101:             try (final FileInputStream fis = new FileInputStream(args[0])) {
>> 
>> There is no need to read from a certificate. I think `encoder.encodeBuffer(new byte[100])` is enough.
>
> changed in the next commit

Some `import`s are not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23661#discussion_r1962072542


More information about the security-dev mailing list