RFR: 8346129: Simplify EdDSA & XDH curve name usage

Anthony Scarpino ascarpino at openjdk.org
Fri Feb 21 17:54:56 UTC 2025


On Thu, 20 Feb 2025 14:20:34 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Hi,
>> 
>> I need a review for the following change. Naming conventions for EdDSA and XDH have inconsistencies between DisabledAlgorithms and KeyPairGenerator. These internal changes help make it more consistent when parsing the actual curve being used vs the broader algorithm name.
>> 
>> thanks
>> 
>> Tony
>
> src/java.base/share/classes/sun/security/util/KeyUtil.java line 189:
> 
>> 187:             case EdECKey ed -> ed.getParams().getName();
>> 188:             case XECKey xe -> ((NamedParameterSpec) xe.getParams()).getName();
>> 189:             default -> key.getAlgorithm();
> 
> Do you also want to add cases for ML-KEM and ML-DSA keys?

@wangweij is planning on name usage for those.  I'm focusing on these older curves.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23647#discussion_r1965944775


More information about the security-dev mailing list