RFR: 8346129: Simplify EdDSA & XDH curve name usage

Sean Mullan mullan at openjdk.org
Fri Feb 21 18:38:54 UTC 2025


On Fri, 21 Feb 2025 17:52:18 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/util/KeyUtil.java line 189:
>> 
>>> 187:             case EdECKey ed -> ed.getParams().getName();
>>> 188:             case XECKey xe -> ((NamedParameterSpec) xe.getParams()).getName();
>>> 189:             default -> key.getAlgorithm();
>> 
>> Do you also want to add cases for ML-KEM and ML-DSA keys?
>
> @wangweij is planning on name usage for those.  I'm focusing on these older curves.

They are already defined. I think you just want to add something like:


If (key.getAlgorithm().equals("ML-KEM") || key.getAlgorithm().equals("ML-DSA")) {
   return ((NamedParameterSpec) key.getParams()).getName();
}


Not urgent, but useful if one of these algorithms were to weaken or be broken for some reason.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23647#discussion_r1966001285


More information about the security-dev mailing list