RFR: 8346129: Simplify EdDSA & XDH curve name usage

Weijun Wang weijun at openjdk.org
Fri Feb 21 20:12:52 UTC 2025


On Fri, 21 Feb 2025 18:36:39 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> @wangweij is planning on name usage for those.  I'm focusing on these older curves.
>
> They are already defined. I think you just want to add something like:
> 
> 
> If (key.getAlgorithm().equals("ML-KEM") || key.getAlgorithm().equals("ML-DSA")) {
>    return ((NamedParameterSpec) key.getParams()).getName();
> }
> 
> 
> Not urgent, but useful if one of these algorithms were to weaken or be broken for some reason.

Or what about this?

        if (key instanceof AsymmetricKey ak) {
            if (ak.getParams() instanceof NamedParameterSpec nps) {
                return nps.getName();
            }
        }
        return key.getAlgorithm();

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23647#discussion_r1966113001


More information about the security-dev mailing list