RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test

Amit Kumar amitkumar at openjdk.org
Wed Jan 8 14:40:08 UTC 2025


On Tue, 7 Jan 2025 16:19:58 GMT, Mikhail Yankelevich <duke at openjdk.org> wrote:

> * Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test
> * Test will now fail if run with JTReg

Also please enable GHA on your repo.

test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line 53:

> 51: 
> 52:         if (System.getProperty("java.class.path").contains("jtreg")){
> 53:             throw new RuntimeException("This is a manual testing, it shouldn't be run with jtreg.");

Was a crash necessary ? Can't we bail out ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22951#issuecomment-2576863253
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1906551938


More information about the security-dev mailing list