RFR: 8344316: Add extra line in security/auth/callback/TextCallbackHandler/Password.java to make clear it is not a JTReg test [v2]
Shivangi Gupta
sshivang at openjdk.org
Fri Jan 10 10:30:41 UTC 2025
On Wed, 8 Jan 2025 06:40:15 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> minor, but to the @bug
>
> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line 53:
>
>> 51:
>> 52: if (System.getProperty("java.class.path").contains("jtreg")){
>> 53: throw new RuntimeException("This is a manual testing, it shouldn't be run with jtreg.");
>
> Was a crash necessary ? Can't we bail out ?
I think it is good to put. As this the manual test and ran by IMT. They are raising issue if the test is failing and actually not going inside the test and checking the steps how to run. As they run all the test using jtreg they will just trigger in bunch. So if we give proper message that "this test will failing while running jtreg , please go and see the steps inside the test to run" will be good
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1910163698
More information about the security-dev
mailing list