RFR: 8347067: Load certificates without explicit trust settings in KeyChainStore

Tim Jacomb duke at openjdk.org
Fri Jan 24 21:17:28 UTC 2025


On Tue, 7 Jan 2025 17:21:50 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> test/jdk/java/security/KeyStore/CheckMacOSKeyChainIntermediateCATrust.java line 43:
>> 
>>> 41: 
>>> 42: /*
>>> 43:  * @test
>> 
>> @alexeybakhtin quick question on how this should be marked as manual.
>> 
>> I see all tests in https://github.com/openjdk/jdk/blob/master/test/jdk/TEST.groups#L256-L259 are manual ones.
>> Is this test automatically included in that?
>> 
>> Or should it be added here?
>> https://github.com/openjdk/jdk/blob/master/test/jdk/TEST.groups#L657
>
> The test should be marked as `@run junit/manual ` and added to the `jdk_security_manual_interactive` part of the TEST.groups

Any idea how I can run the test after making those changes?

The test just gets skipped with:


CONF=release make test TEST=test/jdk/java/security/KeyStore/CheckMacOSKeyChainIntermediateCATrust.java


I've checked through:
https://openjdk.org/jtreg/faq.html#how-do-i-run-only-tests-requiring-manual-intervention

and I saw somewhere mention of passing `-manual` but I can't get that to work with `make test`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22911#discussion_r1905994474


More information about the security-dev mailing list