RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

Koushik Muthukrishnan Thirupattur duke at openjdk.org
Sat Jun 21 23:34:29 UTC 2025


On Mon, 16 Jun 2025 10:38:08 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> * added an automated mixed case option
>> * using multithreading now
>> * added logs for simpler debug
>> * added missing -Djava.security.auth.debug coverage
>
> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into JDK-8357470
>  - JDK-8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase
>    
>    * added an automated mixed case option
>    * using multithreading now
>    * added logs for simpler debug
>    * added missing -Djava.security.auth.debug coverage

test/jdk/sun/security/util/Debug/DebugOptions.java line 174:

> 172: 
> 173:             patternMatches.forEach(params -> {
> 174:                 testsCallables.add(() -> {

Can we consider adding negative tests with invalid/malformed parameters like null, empty strings, unknown keywords, etc?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25391#discussion_r2160178940


More information about the security-dev mailing list