RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Tue Jun 24 10:41:34 UTC 2025
On Sat, 21 Jun 2025 23:18:39 GMT, Koushik Muthukrishnan Thirupattur <duke at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge branch 'master' into JDK-8357470
>> - JDK-8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase
>>
>> * added an automated mixed case option
>> * using multithreading now
>> * added logs for simpler debug
>> * added missing -Djava.security.auth.debug coverage
>
> test/jdk/sun/security/util/Debug/DebugOptions.java line 208:
>
>> 206: });
>> 207:
>> 208: System.out.println("option added to all tests " + Arrays.toString(params));
>
> Optional: consider labeling the log output to make test parameters easier to read when scanning test output
I'd prefer keeping this as is, as the parameters are also logged in the `test*Parameter` when the thread is actually executed. This is just to make sure that the parameters are added to the list of threads, which would be easier in this format, as they are set in this format in the list above.
log:
Option added to all lowercase tests [properties, properties\[.*\|main|\\d{4}-\\d{2}-\\d{2}.*\]:, properties:]
code:
```java
new String[]{"properties",
EXPECTED_PROP_REGEX,
"properties:"},
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25391#discussion_r2163585279
More information about the security-dev
mailing list