RFR: 8156715: TrustStoreManager does not buffer keystore input stream

Mark Powers mpowers at openjdk.org
Mon Jun 23 18:37:28 UTC 2025


On Fri, 20 Jun 2025 20:21:19 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

> Wrap the FileInputStream into a BufferedInputStream which reduces the number of actual file reads when loading a key store.

Update copyright date.

src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 379:

> 377: 
> 378:             if (!"NONE".equals(descriptor.storeName)) {
> 379:                 try (BufferedInputStream fis =

Nit:
`ks` is for KeyStore
`fis` is for FileInputStream
so should `bis` be used for BufferedInputStream?

-------------

PR Review: https://git.openjdk.org/jdk/pull/25920#pullrequestreview-2951160452
PR Review Comment: https://git.openjdk.org/jdk/pull/25920#discussion_r2162294841


More information about the security-dev mailing list