RFR: 8156715: TrustStoreManager does not buffer keystore input stream

[Artur Barashev]

On Mon, 23 Jun 2025 18:34:22 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> Wrap the FileInputStream into a BufferedInputStream which reduces the number of actual file reads when loading a key store.
>
> src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 379:
> 
>> 377: 
>> 378:             if (!"NONE".equals(descriptor.storeName)) {
>> 379:                 try (BufferedInputStream fis =
> 
> Nit:
> `ks` is for KeyStore
> `fis` is for FileInputStream
> so should `bis` be used for BufferedInputStream?

Yes, I also noticed that, will update it together with a copyright, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25920#discussion_r2162318466