RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

Mikhail Yankelevich myankelevich at openjdk.org
Thu Mar 6 11:42:05 UTC 2025


On Thu, 6 Mar 2025 11:20:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - typo
>>  - Merge branch 'master' into JDK-8349348
>>  - JDK-8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
>
> test/jdk/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.java line 28:
> 
>> 26: * @bug 5094825
>> 27: * @summary verify no deadlock if crypto provider in other classloader is used to verify signed jars
>> 28: * @modules java.base/java.security
> 
> Hello Mikhail, `java.security` package is an exported package from `java.base`. So you don't need this `@modules` declaration.

Removed in the next commit, thanks

> test/jdk/java/security/Security/ClassLoaderDeadlock/Deadlock.java line 29:
> 
>> 27:  * @summary make sure we do not deadlock loading signed JAR with getInstance()
>> 28:  * @library ./Deadlock.jar
>> 29:  * @build Deadlock
> 
> `Deadlock` here is the class name of the test itself. So you don't need to `@build` it explicitly.

Removed in the next commit, thanks for noticing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23440#discussion_r1983200862
PR Review Comment: https://git.openjdk.org/jdk/pull/23440#discussion_r1983201527


More information about the security-dev mailing list