RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v2]

Mikhail Yankelevich myankelevich at openjdk.org
Thu Mar 6 11:46:00 UTC 2025


On Thu, 6 Mar 2025 11:21:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - typo
>>  - Merge branch 'master' into JDK-8349348
>>  - JDK-8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
>
> test/jdk/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.java line 30:
> 
>> 28: * @modules java.base/java.security
>> 29: * @library ./Deadlock.jar
>> 30: * @compile -g provider/HashProvider.java
> 
> Is the `-g` needed?

This was a carry over from the script, same as `-Djava.awt.headless=true`. Just tried removing them, they both indeed seem to do nothing when used with jtreg. Should be removed in the next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23440#discussion_r1983206286


More information about the security-dev mailing list