RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v4]
Fernando Guallini
fguallini at openjdk.org
Fri Mar 21 12:00:57 UTC 2025
> The following tests are marked with @ignore (not running):
>
> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting the clientMode after the handshake has begun is not permitted, but this was failing intermittently due to a race condition, it was possible that SetClientMode was called before the client socket was updated with handshake isNegotiated = true. The fix is to introduce a latch to sync between client and main threads. Included additional refactoring to ensure test stability.
>
> - sun/security/ssl/SSLSocketImpl/NonAutoClose.java: This test should only run in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. Included additional refactoring to ensure test stability.
>
> Executed both tests 10K times, no test flakiness found
Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
using assertThrows
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23898/files
- new: https://git.openjdk.org/jdk/pull/23898/files/0133c60f..2741a197
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23898&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23898&range=02-03
Stats: 12 lines in 1 file changed: 2 ins; 5 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/23898.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23898/head:pull/23898
PR: https://git.openjdk.org/jdk/pull/23898
More information about the security-dev
mailing list