RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

Fernando Guallini fguallini at openjdk.org
Fri Mar 21 12:00:57 UTC 2025


On Thu, 20 Mar 2025 18:02:49 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   latch await
>
> test/jdk/sun/security/ssl/SSLSocketImpl/SetClientMode.java line 110:
> 
>> 108:                 } catch (IllegalArgumentException iae) {
>> 109:                     System.out.println("succeeded, we can't set the client mode");
>> 110:                 }
> 
> I suggest using `runAndCheckException` from /test/lib here instead of try/catch construct.

Sure, but using assertThrows instead. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23898#discussion_r2007442469


More information about the security-dev mailing list