RFR: 8298420: PEM API: Implementation (Preview) [v15]

Mon May 12 18:52:07 UTC 2025

On Fri, 9 May 2025 22:08:00 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/spec/PKCS8EncodedKeySpec.java line 41:
>> 
>>> 39:  *   privateKeyAlgorithm PrivateKeyAlgorithmIdentifier,
>>> 40:  *   privateKey PrivateKey,
>>> 41:  *   attributes       [0] IMPLICIT Attributes OPTIONAL,
>> 
>> IMPLICIT has been removed in RFC 5958. Also to be consistent with 5958, I think you should change `PrivateKeyInfo` to `OneAsymmetricKey` and add an addtional line with `PrivateKeyInfo ::= OneAsymmetricKey`.
>
> Ok.
> 
> Whats the reason `PrivateKeyInfo` have @code on it. It's not a class or a method.  It's just a term.

It is already in a pre-formatted block, so it is fine as-is w/o specifically putting @code around it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2085263032