RFR: 8298420: PEM API: Implementation (Preview) [v15]

[Sean Mullan]

On Sat, 10 May 2025 01:24:28 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 79:
>> 
>>> 77: 
>>> 78:     /* PKCS8 version of the PEM */
>>> 79:     protected int version;
>> 
>> Do these need to be protected? It doesn't seem like any subclasses need them.
>
> I think I wanted to use it in the subclasses, but later realized the subclasses needed to parse it again anyway for algorithms-specific values.  I can make it private.

These are still protected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2085569163