RFR: 8349546: Linux support for Kerberos "nativeccache" functionality [v10]

[Nick Hall]

On Wed, 12 Nov 2025 00:13:27 GMT, Shawn M Emery <duke at openjdk.org> wrote:

>> Nick Hall has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address second set of @erikj79's build comments
>
> src/java.security.jgss/share/classes/sun/security/krb5/Credentials.java line 335:
> 
>> 333:             if (OperatingSystem.isWindows() ||
>> 334:                     OperatingSystem.isMacOS() ||
>> 335:                         OperatingSystem.isLinux()) {
> 
> nit: extra tab?

This is the overall structure currently:

            if (OperatingSystem.isWindows() ||
                    OperatingSystem.isMacOS() ||
                        OperatingSystem.isLinux()) {


Would you prefer the second two line up or all line up?  It _looks_ like generally the JDK source I've looked at would line them all up (although that's not what was there before!)?

> test/jdk/sun/security/krb5/native/libNativeCredentialCacheHelper.c line 143:
> 
>> 141: }
>> 142: 
>> 143: 
> 
> nit: extra line

Thanks, fixed in next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2517957978
PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2517961143