RFR: 8349546: Linux support for Kerberos "nativeccache" functionality [v10]

[Shawn M Emery]

On Wed, 12 Nov 2025 11:34:13 GMT, Nick Hall <duke at openjdk.org> wrote:

>> src/java.security.jgss/share/classes/sun/security/krb5/Credentials.java line 335:
>> 
>>> 333:             if (OperatingSystem.isWindows() ||
>>> 334:                     OperatingSystem.isMacOS() ||
>>> 335:                         OperatingSystem.isLinux()) {
>> 
>> nit: extra tab?
>
> This is the overall structure currently:
> 
>             if (OperatingSystem.isWindows() ||
>                     OperatingSystem.isMacOS() ||
>                         OperatingSystem.isLinux()) {
> 
> 
> Would you prefer the second two line up or all line up?  It _looks_ like generally the JDK source I've looked at would line them all up (although that's not what was there before!)?

The following would meet code conventions:

            if (OperatingSystem.isWindows() || OperatingSystem.isMacOS()
                    || OperatingSystem.isLinux()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2519995635