RFR: 8372004: Have SSLLogger implement System.Logger [v3]
Daniel Fuchs
dfuchs at openjdk.org
Tue Nov 18 18:15:46 UTC 2025
On Tue, 18 Nov 2025 16:48:48 GMT, Sean Coffey <coffeys at openjdk.org> wrote:
>> `SSLLogger` utilizes `System.Logger` if the `javax.net.debug` system property key value is empty. However, since that class doesn't implement `SSLogger`, it misses the advantage of highlighting the exact calling site for each log statement. Having `SSLLogger `simply implement `System.Logger` fixes this
>>
>> I've also taken this opportunity to refractor the `isOn` boolean in `SSLLogger`. Encapsulated that boolean in a new method which callers can now use. I also used `ForceInline` directory on that method. Thanks to @dfuch for suggestions on that front.
>>
>> Also updated an existing unit testcase to test for the new functionality
>
> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments from Daniel
Looks good to me! Since I'm not a typical Reviewer for security-libs then please obtain an additional review from a Reviewer from that area before integrating.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28376#pullrequestreview-3479140282
More information about the security-dev
mailing list