RFR: 8372004: Have SSLLogger implement System.Logger [v3]

Weijun Wang weijun at openjdk.org
Wed Nov 19 16:07:34 UTC 2025


On Tue, 18 Nov 2025 16:48:48 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> `SSLLogger` utilizes `System.Logger` if the `javax.net.debug` system property key value is empty. However, since that class doesn't implement `SSLogger`, it misses the advantage of highlighting the exact calling site for each log statement.  Having `SSLLogger `simply implement `System.Logger` fixes this
>> 
>> I've also taken this opportunity to refractor the `isOn` boolean in `SSLLogger`. Encapsulated that boolean in a new method which callers can now use. I also used `ForceInline` directory on that method. Thanks to @dfuch for suggestions on that front.
>> 
>> Also updated an existing unit testcase to test for the new functionality
>
> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments from Daniel

Looks good.

I assume except for `SSLLogger` itself and the test change, everything else is just `s/isOn/isOn()/`, right? I quickly paged down and see no other significant changes.

-------------

Marked as reviewed by weijun (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28376#pullrequestreview-3483488425


More information about the security-dev mailing list