RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v4]

Rajan Halade rhalade at openjdk.org
Fri Nov 21 18:46:41 UTC 2025


On Tue, 23 Sep 2025 15:26:31 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java line 98:
>> 
>>> 96:                     hashAlg,
>>> 97:                     mgfHashAlg);
>>> 98:             skipTest = true;
>> 
>> should this test also be split into separate @test blocks? There are about 18 test cases and 17 of them could pass and the last one skipped and the test gets marked as skipped.
>
> There should be no skips in this test with nss, so I don't think this should be an issue here. Splitting this into different `@test` would be though, as it will increase the execution time significantly.

This test should also be updated to maintain a list of skipped tests. Right now the skipTest logic is flawed and it won't be marked as skipped if last runTest resets it to false.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2550655149


More information about the security-dev mailing list