RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v4]
Mikhail Yankelevich
myankelevich at openjdk.org
Fri Nov 21 19:18:58 UTC 2025
On Fri, 21 Nov 2025 18:40:46 GMT, Rajan Halade <rhalade at openjdk.org> wrote:
>> There should be no skips in this test with nss, so I don't think this should be an issue here. Splitting this into different `@test` would be though, as it will increase the execution time significantly.
>
> This test should also be updated to maintain a list of skipped tests. Right now the skipTest logic is flawed and it won't be marked as skipped if last runTest resets it to false.
@rhalade yes, I agree. Didn't notice this. Thanks for noticing
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2550731560
More information about the security-dev
mailing list