RFR: 8326609: New AES implementation with updates specified in FIPS 197 [v4]

Wed Oct 15 18:53:55 UTC 2025

On Wed, 15 Oct 2025 18:45:24 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Shawn M Emery has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add remaining files to be staged
>
> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 55:
> 
>> 53: 
>> 54:     private static final int AES_256_ROUNDS = 14;
>> 55:     private static final int AES_256_NKEYS = 32;
> 
> The `AES_XXX_NKEYS` constants (valued 16, 24, 32) are also defined in `AESConstants` class, maybe we can just refer to that class instead of duplicate the definition here?

Or, merge the values defined in `AESConstants` into this class. Either way is fine with me as long as no duplicated values.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2433622686