RFR: 8326609: New AES implementation with updates specified in FIPS 197 [v4]

Shawn M Emery duke at openjdk.org
Wed Oct 15 23:04:13 UTC 2025


On Wed, 15 Oct 2025 18:51:29 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/AES_Crypt.java line 55:
>> 
>>> 53: 
>>> 54:     private static final int AES_256_ROUNDS = 14;
>>> 55:     private static final int AES_256_NKEYS = 32;
>> 
>> The `AES_XXX_NKEYS` constants (valued 16, 24, 32) are also defined in `AESConstants` class, maybe we can just refer to that class instead of duplicate the definition here?
>
> Or, merge the values defined in `AESConstants` into this class. Either way is fine with me as long as no duplicated values.

I've made the update that references the AESConstants to avoid duplication.  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27807#discussion_r2434164972


More information about the security-dev mailing list