RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v8]

Mikhail Yankelevich myankelevich at openjdk.org
Tue Oct 21 22:12:54 UTC 2025


On Tue, 21 Oct 2025 22:05:49 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed log check and renamed logs from keymanager to ssl,keymanager
>
> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 301:
> 
>> 299:                             if (SSLLogger.isOn
>> 300:                                     && SSLLogger
>> 301:                                         .isOn("ssl,keymanager")) {
> 
> This line can be moved up

Just trying to keep the line within 80 characters. The same for the comment on line 259

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2449826598


More information about the security-dev mailing list