RFR: 8369995: Implement extra logging and/or propagate errors in X509KeyManagerImpl and fix StringIndexOutOfBoundsException [v8]

Artur Barashev abarashev at openjdk.org
Wed Oct 22 13:19:02 UTC 2025


On Tue, 21 Oct 2025 22:10:34 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 301:
>> 
>>> 299:                             if (SSLLogger.isOn
>>> 300:                                     && SSLLogger
>>> 301:                                         .isOn("ssl,keymanager")) {
>> 
>> This line can be moved up
>
> Just trying to keep the line within 80 characters. The same for the comment on line 259

It won't be more than 80 characters if you do `&& SSLLogger.isOn("ssl,keymanager")) {`. The same for other comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27851#discussion_r2452069461


More information about the security-dev mailing list