RFR: 8368493: Disable most test JSSE debug output by default, and increase the test default maximum output log size [v2]
Bradford Wetmore
wetmore at openjdk.org
Wed Oct 22 19:45:36 UTC 2025
On Wed, 22 Oct 2025 18:20:36 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adjusted sizes to be more reasonable
>
> test/jdk/javax/net/ssl/HttpsURLConnection/Equals.java line 50:
>
>> 48: * after gaining some familiarity with this application.
>> 49: */
>> 50: private static final boolean debug = false;
>
> Instead of hardcoding this, it's more flexible to use `Boolean.getBoolean("test.debug")` so you can run a test with debug output but not have to recompile the test.
I don't see much difference between adding a System Property to the invocation vs. recompiling the test which is automatically done when running jtreg.
There are only 8 tests currently using `test.debug` out of just under 400 tests. If SQE is interested in switching to this model, let's consider fixing throughout.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27455#discussion_r2453174709
More information about the security-dev
mailing list