RFR: 8368493: Disable most test JSSE debug output by default, and increase the test default maximum output log size [v2]
Matthew Donovan
mdonovan at openjdk.org
Thu Oct 23 11:20:04 UTC 2025
On Wed, 22 Oct 2025 19:43:13 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> test/jdk/javax/net/ssl/HttpsURLConnection/Equals.java line 50:
>>
>>> 48: * after gaining some familiarity with this application.
>>> 49: */
>>> 50: private static final boolean debug = false;
>>
>> Instead of hardcoding this, it's more flexible to use `Boolean.getBoolean("test.debug")` so you can run a test with debug output but not have to recompile the test.
>
> I don't see much difference between adding a System Property to the invocation vs. recompiling the test which is automatically done when running jtreg.
>
> There are only 8 tests currently using `test.debug` out of just under 400 tests. If SQE is interested in switching to this model, let's consider fixing throughout.
SQE is interested in removing the hardcoded `debug` flags but it's been lower priority. When a test fails on a specific build, it's nice to be able to run the test on that build with enabled debugging without making any changes or having to remember the correct command line incantation. As I thought about this more, I realized that we can specify the `javax.net.debug` property on the command line as well. So is this pattern necessary at all?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27455#discussion_r2454775251
More information about the security-dev
mailing list