RFR: 8368493: Disable most test JSSE debug output by default, and increase the test default maximum output log size [v2]
Bradford Wetmore
wetmore at openjdk.org
Thu Oct 23 16:13:47 UTC 2025
On Thu, 23 Oct 2025 11:17:11 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> I don't see much difference between adding a System Property to the invocation vs. recompiling the test which is automatically done when running jtreg.
>>
>> There are only 8 tests currently using `test.debug` out of just under 400 tests. If SQE is interested in switching to this model, let's consider fixing throughout.
>
> SQE is interested in removing the hardcoded `debug` flags but it's been lower priority. When a test fails on a specific build, it's nice to be able to run the test on that build with enabled debugging without making any changes or having to remember the correct command line incantation. As I thought about this more, I realized that we can specify the `javax.net.debug` property on the command line as well. So is this pattern necessary at all?
We added it 20+ years ago for ease of development, as it's a common mode to want to enable during dev, but not necessarily keep on full time. A simple false->true->false change is all that's needed, vs. remembering `System.setProperty("javax.net.debug, ...)`
Most current instances can do either option, as the code just does `if (debug) System.setProperty(); `
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27455#discussion_r2455824277
More information about the security-dev
mailing list