RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods

Andrey Turbanov aturbanov at openjdk.org
Thu Sep 4 09:07:43 UTC 2025


On Thu, 4 Sep 2025 06:36:20 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

> [JDK-8356439] (#26413) conflicted with [JDK-8362893] (#26493), caused `tier1` failures, and hence, backed out in [JDK-8366693] (#27050). This PR reintroduces JDK-8356439 with sufficient fixes.
> 
> [JDK-8356439]: https://bugs.openjdk.org/browse/JDK-8356439
> [JDK-8362893]: https://bugs.openjdk.org/browse/JDK-8362893
> [JDK-8366693]: https://bugs.openjdk.org/browse/JDK-8366693

src/java.base/share/classes/java/lang/String.java line 691:

> 689:     }
> 690: 
> 691:     /*

Is there a reason, why it can't be _converted_ to a proper javadoc?
Suggestion:

    /**

src/java.base/share/classes/java/lang/String.java line 797:

> 795:      * @param cs charset the byte array encoded in
> 796:      *
> 797:      * @throws CharacterCodingException for malformed input or unmappable characters

Shouldn't we document NPE here too?
I mean there is NPE note in `private` method `newStringUTF8OrThrow`, but not in the more widely opened `newStringOrThrow`. That's confusing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27084#discussion_r2321347469
PR Review Comment: https://git.openjdk.org/jdk/pull/27084#discussion_r2321350608


More information about the security-dev mailing list