RFR: 8366765: [REDO] Rename JavaLangAccess::*NoRepl methods [v2]
Volkan Yazici
vyazici at openjdk.org
Thu Sep 4 09:41:45 UTC 2025
On Thu, 4 Sep 2025 09:01:25 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve docs
>
> src/java.base/share/classes/java/lang/String.java line 691:
>
>> 689: }
>> 690:
>> 691: /*
>
> Is there a reason, why it can't be _converted_ to a proper javadoc?
> Suggestion:
>
> /**
Improved as suggested in 8d7dcb4d410.
> src/java.base/share/classes/java/lang/String.java line 797:
>
>> 795: * @param cs charset the byte array encoded in
>> 796: *
>> 797: * @throws CharacterCodingException for malformed input or unmappable characters
>
> Shouldn't we document NPE here too?
> I mean there is NPE note in `private` method `newStringUTF8OrThrow`, but not in the more widely opened `newStringOrThrow`. That's confusing.
Improved NPE docs in 8d7dcb4d410.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27084#discussion_r2321446143
PR Review Comment: https://git.openjdk.org/jdk/pull/27084#discussion_r2321445517
More information about the security-dev
mailing list