RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't [v2]
Matthew Donovan
mdonovan at openjdk.org
Fri Sep 5 13:46:51 UTC 2025
> This PR updates PKCS11 tests to better handle NSS version numbers. The previous code treated the version numbers as double values and used comparison operators. The problem is that it incorrectly treats 3.111 as between 3.11 and 3.12. This update parses and compares the major and minor version numbers separately.
Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
refactored to encapsulate the version as a record instead of doing repeated string parsing
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27095/files
- new: https://git.openjdk.org/jdk/pull/27095/files/c869d478..cd250fab
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27095&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27095&range=00-01
Stats: 62 lines in 5 files changed: 18 ins; 17 del; 27 mod
Patch: https://git.openjdk.org/jdk/pull/27095.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27095/head:pull/27095
PR: https://git.openjdk.org/jdk/pull/27095
More information about the security-dev
mailing list