RFR: 8366182: Some PKCS11Tests are being skipped when they shouldn't [v3]
Matthew Donovan
mdonovan at openjdk.org
Wed Sep 17 12:29:36 UTC 2025
> This PR updates PKCS11 tests to better handle NSS version numbers. The previous code treated the version numbers as double values and used comparison operators. The problem is that it incorrectly treats 3.111 as between 3.11 and 3.12. This update parses and compares the major and minor version numbers separately.
Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into nss-skipped
- refactored to encapsulate the version as a record instead of doing repeated string parsing
- 8366182: Some PKCS11Tests are being skipped when they shouldn't
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27095/files
- new: https://git.openjdk.org/jdk/pull/27095/files/cd250fab..da7faa4c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27095&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27095&range=01-02
Stats: 38282 lines in 1123 files changed: 19273 ins; 10145 del; 8864 mod
Patch: https://git.openjdk.org/jdk/pull/27095.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27095/head:pull/27095
PR: https://git.openjdk.org/jdk/pull/27095
More information about the security-dev
mailing list