RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v2]

[Matthew Donovan]

On Tue, 23 Sep 2025 15:33:00 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> * test/jdk/sun/security/pkcs11/Signature/InitAgainPSS.java
>> * test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java
>> * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS.java
>> * test/jdk/sun/security/pkcs11/Signature/SigInteropPSS2.java
>> * test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java
>> * test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS2.java
>> * test/jdk/sun/security/pkcs11/Signature/TestDSA.java
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   renamed  id

test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 59:

> 57: 
> 58:     private static final int[] KEYSIZES = { 2048, 3072 };
> 59:     private static String[] DIGESTS = {

suggested name changes DIGESTS = "SHA_DIGESTS" and "DIGESTS_NEW" = "SHA3_DIGESTS"

test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 82:

> 80: 
> 81:     public static void main(String[] args) throws Exception {
> 82:         if (args.length>0 && "new-alg".equals(args[0])){

The parameter passed for the sha3 tests is "new-algS" so this will always run the SHA algorithms. If you keep the SHA3 tests, I suggest renaming the parameter to sha3 in the @run instruction and here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2375689908
PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2375687531