RFR: 8367994: test/jdk/sun/security/pkcs11/Signature/ tests pass when they should skip [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Wed Sep 24 13:32:50 UTC 2025
On Wed, 24 Sep 2025 12:50:10 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> renamed id
>
> test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 82:
>
>> 80:
>> 81: public static void main(String[] args) throws Exception {
>> 82: if (args.length>0 && "new-alg".equals(args[0])){
>
> The parameter passed for the sha3 tests is "new-algS" so this will always run the SHA algorithms. If you keep the SHA3 tests, I suggest renaming the parameter to sha3 in the @run instruction and here.
Missed this one, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27367#discussion_r2375812191
More information about the security-dev
mailing list