RFR: 8365072: Refactor tests to use PEM API (Phase 2) [v2]
Mikhail Yankelevich
myankelevich at openjdk.org
Mon Sep 29 09:58:37 UTC 2025
On Fri, 26 Sep 2025 17:59:09 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Francesco's comment
>>
>> Co-authored-by: Francesco Andreuzzi <andreuzzi.francesco at gmail.com>
>
> test/jdk/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java line 45:
>
>> 43: import java.security.PEMDecoder;
>> 44: import java.security.Security;
>> 45: import java.security.cert.CertPathBuilder;
>
> Did you intentionally list every `java.security.cert` class used or did the IDE do that? The changes was made with a number of tests and other import paths, but I'm only mentioning it here. Just a suggestion that `*` looks cleaner.
Just removing all wildcard imports, when I touch the file. Was asked to remove several times before and in general wildcard is not the best practice, as this affect compile time, which is important for `jtreg` tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27194#discussion_r2387367113
More information about the security-dev
mailing list