RFR: 8374808: Add new methods to KeyStore and KeyStoreSpi that return the creation date as an Instant instead of Date [v8]

[Weijun Wang]

On Thu, 22 Jan 2026 13:12:29 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Hi!
>> 
>> This is my proposal to transfer `KeyStore` and `KeyStoreSpi` with internal implementations to use `Instance`s instead of `Date`s. 
>> I would be very grateful for your comments and suggestions.
>> 
>> Thanks!
>> 
>> P.S. this is related to [JDK-8350953](https://bugs.openjdk.org/browse/JDK-8350953)
>
> Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   patter matching comment

src/java.base/macosx/classes/apple/security/KeychainStore.java line 411:

> 409:     public Date engineGetCreationDate(String alias) {
> 410:         final Instant instant = this.engineGetCreationInstant(alias);
> 411:         if (instant == null){

Add a space between `null)` and `{`.

Same in `JceKeyStore` and `PKCS12KeyStore`.

src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 219:

> 217:     public Date engineGetCreationDate(String alias) {
> 218:         final Instant instant = this.engineGetCreationInstant(alias);
> 219:         if (instant == null){

Add a space after `null)`.

src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 640:

> 638:                         dos.writeLong(
> 639:                                 ((TrustedCertEntry)entry).date.toEpochMilli()
> 640:                         );

Not very common to write `);` on a new line.

Same below on line 659. Also in `JavaKeyStore` line 633.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2770664836
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2770629205
PR Review Comment: https://git.openjdk.org/jdk/pull/29140#discussion_r2770672464